GH-49697: [C++][CI] Check IPC file body bounds are in sync with decoder outcome#49698
Merged
pitrou merged 1 commit intoapache:mainfrom Apr 13, 2026
Merged
Conversation
Member
Author
|
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
gh49697-ipc-file-validation
branch
from
44711e3 to
08d81ea
Compare
pitrou
force-pushed
the
gh49697-ipc-file-validation
branch
2 times, most recently
from
ad0aab4 to
3b2d101
Compare
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: 3b2d101 Submitted crossbow builds: ursacomputing/crossbow @ actions-265034e4bd
|
Member
Author
|
@lidavidm Could you perhaps take a look? |
Member
Author
|
@raulcd This may be a good last-minute fix for 24.0.0. |
lidavidm
approved these changes
Apr 13, 2026
github-actions
bot
added
awaiting merge
pitrou
force-pushed
the
gh49697-ipc-file-validation
branch
from
3b2d101 to
c2daf38
Compare
lidavidm
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When we read an IPC message from an IPC file, we validate its associated body size against the amount required by the streaming decoder. However, we're currently only checking that the body size is large enough, not that it's exactly as expected.
An invalid IPC file might advertise in its footer a
metaDataLengththat's larger than the actual serialized Flatbuffers payload. In that case, the associated body would start before the offset computed from the IPC file footer.What changes are included in this PR?
ensure_alignmentoption to buffers read from IPC.Are these changes tested?
By additional fuzz regression file.
Are there any user-facing changes?
No.